On Fri, 2018-07-13 at 14:39 -0500, Benjamin Marzinski wrote: > The one point of these functions was for _filter_path(), and that > wasn't > improved by using them. Since filter_path() only printed one message > at > the end, you could have situations where the wwid was blacklisted, > but > the blacklist message included the vendor/product instead. Also, the > protocol and property messages were printed twice, and if the device > was > on multiple whitelists, only the last one is printed. > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > --- > libmultipath/blacklist.c | 168 +++++++++++++++++++---------------- > ------------ > libmultipath/blacklist.h | 2 +- > libmultipath/configure.c | 2 +- > libmultipath/discovery.c | 2 +- > 4 files changed, 71 insertions(+), 103 deletions(-) Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> One remark: > +filter_device (vector blist, vector elist, char * vendor, char * > product, > + char * dev) While we are at it, could we further simplify these to take a "conf" argument instead of elist and blist? Martin -- Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
