On Sun, Jun 24, 2018 at 09:09:34PM +0200, Martin Wilck wrote: > Hi Christophe, > > this is v3 of my small set of libmpathpersist fixes. It's based > on your latest push. Sorry again for missing that. > > Changes wrt v2: > - rebased to latest upstream (39ad8dc8) > - added another gcc 8.1 fix, and another small patch I hadn't > submitted yet > > Changes wrt v1: > - introduce and use get_unaligned_be64 (Bart van Assche) > - add test for (get|put)_unaligned_bexx functions > > Note: we have both the "unaligned" and the "beXY_to_cpu" APIs > now, for essentially the same purpose. I wonder if we should > settle on a single API instead. I am unsure if beXY_to_cpu() has > alignment issues on some architectures (I don't think there are > issues on our current main target platforms). If yes, I believe that > we'd be on the safe side using the "unaligned" API. > Anyway, that could be done in a follow-up patch. > > Thanks, > Martin ACK for the set. -Ben > > Martin Wilck (10): > libmpathpersist: remove duplicate test in readfullstatus > libmpathpersist: fix typo in mpath_format_readfullstatus > libmpathpersist: fix stack overflow in mpath_format_readfullstatus() > libmultipath: add (get|put)_unaligned_be64 > multipath-tools/tests: add tests for get_unaligned_beXX > libmpathpersist: fix byte swapping for big endian systems > (lib)mpathpersist: use O_RDONLY file descriptors > libmultipath: fix gcc 8.1 "truncated output" warnings > multipathd: fix buffer size in cli_getprkey() > libmultipath: avoid error messages from RDAC check > > libmpathpersist/mpath_persist.c | 8 +-- > libmpathpersist/mpath_pr_ioctl.c | 75 +++++++++---------------- > libmultipath/propsel.c | 2 + > libmultipath/sysfs.c | 4 +- > libmultipath/unaligned.h | 16 ++++++ > libmultipath/util.c | 4 +- > mpathpersist/main.c | 2 +- > multipathd/cli_handlers.c | 4 +- > tests/Makefile | 2 +- > tests/unaligned.c | 96 ++++++++++++++++++++++++++++++++ > 10 files changed, 150 insertions(+), 63 deletions(-) > create mode 100644 tests/unaligned.c > > -- > 2.17.1 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
