Re: [PATCH REPOST] dm rq: remove BUG_ON(!irqs_disabled) check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018-05-04 11:53:12 [-0400], Mike Snitzer wrote:
> the queue_lock hasn't been removed for the old .request_fn path in block
> core -- which dm_old_request_fn is providing the hook for.
> 
> This BUG_ON() documents that reality.
> 
> Commit 2eb6e1e3aa87 made it such that work is queued into an irq enabled
> context.   But it never changed the fact that old block core's
> .request_fn (and as such dm_old_request_fn) is called with irqs
> disabled.

As per history it looked different, sorry. Is there a lock that is
supposed to be held?

Sebastian

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel



[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux