Re: [PATCH 04/12] multipathd: log thread cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-03-14 at 12:46 -0500, Benjamin Marzinski wrote:
> The function log_thread_flush() is an exact copy of flush_lgoqueue(),
> so
> both clearly don't need to exist. Also, There is no reason to make
> all
> of the log thread variables global.  The only time any of them were
> being used outside of log_thread.c, was to reset the log.  This code
> should never be run if the log_thread isn't running, so it makes more
> sense to live inside of log_thread.c
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> ---

Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>


-- 
Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux