Re: [PATCH] multipath-tools: Remove trailing/leading whitespaces and reformat code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2018-03-09 at 23:00 +0100, Xose Vazquez Perez wrote:
>  # Check whether a function with name $1 has been declared in header file $2.
> -check_func =								       \
> -    $(shell								       \
> +check_func = $(shell \
>  	if grep -Eq "^[^[:blank:]]+[[:blank:]]+$1[[:blank:]]*(.*)*" "$2"; then \
> -	   found=1;							       \
> -	   status="yes";						       \
> -	else								       \
> -	   found=0;							       \
> -	   status="no";							       \
> -	fi;								       \
> -	echo 1>&2 "Checking for $1 in $2 ... $$status";			       \
> -	echo "$$found"							       \
> -    )
> +		found=1; \
> +		status="yes"; \
> +	else \
> +		found=0; \
> +		status="no"; \
> +	fi; \
> +	echo 1>&2 "Checking for $1 in $2 ... $$status"; \
> +	echo "$$found" \
> +	)

Whitespace-only patches are not useful, and on top of that you are making the code
much more ugly by breaking the alignment of the trailing backslahes. Yikes!

Bart.



--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel



[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux