Re: [PATCH v2 2/2] multipathd: start marginal path checker thread lazily

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/06/2018 10:18 PM, Martin Wilck wrote:
> I noticed that the io_error checker thread accounts for most of the
> activity of multipathd even if the marginal path checking paramters
> are not set (which is still the default in most installations I assume).
> 
> Therefore, start the io_error checker thread only if there's at least
> one map with marginal error path checking configured. Also, make sure
> the thread is really up when start_io_err_stat_thread() returns.
> 
> This requires adding a "vecs" argument to setup_map, because vecs
> needs to be passed to the io_error checking code.
> 
> Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> ---
>  libmultipath/configure.c   | 14 +++++++++---
>  libmultipath/configure.h   |  3 ++-
>  libmultipath/io_err_stat.c | 55 ++++++++++++++++++++++++++++++++++++++++++----
>  libmultipath/structs_vec.c |  3 ++-
>  multipathd/cli_handlers.c  |  2 +-
>  multipathd/main.c          |  8 ++-----
>  6 files changed, 69 insertions(+), 16 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@xxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux