On 03/06/2018 12:14 AM, Martin Wilck wrote: > Updating the prio values for printing makes no sense. The user wants to see > the prio values multipath is actually using for path group selection, and > updating the values here means actually lying to the user if the prio values > have changed, but multipathd hasn't updated them internally. > > If we really don't update the pathgroup prios when we need to, this should be > fixed elsewhere. The current wrong output would just hide that if it occured. > > Moreover, correctness forbids changing properties so deeply in a code path > that's supposed to print them only. Finally, this piece of code prevents the > print.c code to be converted to proper "const" usage. > > Signed-off-by: Martin Wilck <mwilck@xxxxxxxx> > Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > --- > libmultipath/print.c | 7 ------- > 1 file changed, 7 deletions(-) > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
