On Mon, 2018-03-05 at 21:47 +0100, Martin Wilck wrote: > On Mon, 2018-03-05 at 19:18 +0000, Bart Van Assche wrote: > > On Mon, 2018-03-05 at 20:14 +0100, Martin Wilck wrote: > > > Unless you object, I'll repost your series rebased on mine. > > > > Hello Martin, > > > > Before you start working on that: has your patch series already been > > posted > > on the dm-devel mailing list? > > Yes. "PATCH v2 00/20] Various multipath-tools fixes" ff. > https://www.redhat.com/archives/dm-devel/2018-January/msg00219.html Ah, thanks, but unfortunately these patches are no longer in my mailbox. I pulled these from https://github.com/openSUSE/multipath-tools. I'm fine with my patches being rebased on top of your series, whether or not the following issues get addressed: * Several patches that are on the upstream-queue branch introduce trailing whitespace. * The macro FREE_CONST() should never have been introduced. Introducing such a macro namely introduces the risk of calling free() for a string constant, something that should never happen. Have you considered to declare dynamically allocated strings, e.g. the result of strdup(), as char * instead of const char * ? I think with that change the FREE_CONST() macro definitions can be removed again. Thanks, Bart. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
