Re: [RFC PATCH 01/20] multipath(d)/Makefile: add explicit dependency on libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 20, 2018 at 02:26:39PM +0100, Martin Wilck wrote:
> Otherwise the binaries won't be re-linked if the libraries change.
> 

Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>

> Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> ---
>  multipath/Makefile  | 2 +-
>  multipathd/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/multipath/Makefile b/multipath/Makefile
> index 654568af3576..0828a8f72db7 100644
> --- a/multipath/Makefile
> +++ b/multipath/Makefile
> @@ -14,7 +14,7 @@ OBJS = main.o
>  
>  all: $(EXEC)
>  
> -$(EXEC): $(OBJS)
> +$(EXEC): $(OBJS) $(multipathdir)/libmultipath.so $(mpathcmddir)/libmpathcmd.so
>  	$(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS) $(LIBDEPS)
>  	$(GZIP) $(EXEC).8 > $(EXEC).8.gz
>  	$(GZIP) $(EXEC).conf.5 > $(EXEC).conf.5.gz
> diff --git a/multipathd/Makefile b/multipathd/Makefile
> index 251690ec5e2a..4c9d29634160 100644
> --- a/multipathd/Makefile
> +++ b/multipathd/Makefile
> @@ -28,7 +28,7 @@ EXEC = multipathd
>  
>  all : $(EXEC)
>  
> -$(EXEC): $(OBJS)
> +$(EXEC): $(OBJS) $(multipathdir)/libmultipath.so $(mpathcmddir)/libmpathcmd.so
>  	$(CC) $(CFLAGS) $(OBJS) $(LDFLAGS) -o $(EXEC) $(LIBDEPS)
>  	$(GZIP) $(EXEC).8 > $(EXEC).8.gz
>  
> -- 
> 2.16.1

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel



[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux