Ming, > + * Block layer and block driver specific status, which is ususally returnd ^^^^^^^ > + * from driver to block layer in IO path. Given that the comment blurb is long and the flag not defined until later, it is not entirely obvious that you are documenting BLK_STS_DEV_RESOURCE. So please make that clear at the beginning of the comment. > + * If driver isn't sure if the queue can be run again for dealing with the > + * current request after this kind of resource is available, please return > + * BLK_STS_SOURCE, for example, when memory allocation, DMA Mapping or other ^^^^^^^^^^^^^^ -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel