On 2018-01-11 23:24, Martin Wilck wrote: > I'm not sure what you mean with "standard envvars" here. Is it "CFLAGS" > and "LDFLAGS"? If that's what you mean, I disagree. Yes, I was especially talking about CFLAGS. > CFLAGS handling is correct this way - CFLAGS should represent the final > list of options passed to the compiler. Typically the Makefile > assembles this list from internal project settings and user input. > > Currently, setting OPTFLAGS is the preferred way to customize > multipath-tools build. And this works for you with the current multipath-tools package? Sorry, maybe I am missing something but from my understanding the Makefile is currently setting OPTFLAGS via OPTFLAGS = -O2 -g .... So any OPTFLAGS value you are currently passing should be ignored at the moment. That's why Bart and I independently from each other created this patch. > If changes are needed, I'd prefer Bart's suggestion. Like said, Bart's variant works for me, too. We can pick his patch. -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
