Hi Bart,
On Mon, 2017-12-11 at 16:45 -0800, Bart Van Assche wrote:
> Compiling the multipath-tools source code with e.g. sparse requires
> to specify additional compiler flags on the command line. Modify the
> Makefile such that this becomes possible.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> ---
> Makefile.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile.inc b/Makefile.inc
> index 29c290a22e8f..d953f5ef34e6 100644
> --- a/Makefile.inc
> +++ b/Makefile.inc
> @@ -90,7 +90,8 @@ OPTFLAGS = -O2 -g -pipe -Wall -Wextra
> -Wformat=2 -Werror=implicit-int \
> -Wp,-D_FORTIFY_SOURCE=2 $(STACKPROT) \
> --param=ssp-buffer-size=4
>
> -CFLAGS = $(OPTFLAGS) -DLIB_STRING=\"${LIB}\"
> -DRUN_DIR=\"${RUN}\"
> +CFLAGS := $(OPTFLAGS) -DLIB_STRING=\"${LIB}\"
> -DRUN_DIR=\"${RUN}\" \
> + $(CFLAGS)
I'd prefer the variable passed from user space not to be called CFLAGS
but e.g. EXTRA_CFLAGS. Otherwise, ack.
Martin
> BIN_CFLAGS = -fPIE -DPIE
> LIB_CFLAGS = -fPIC
> SHARED_FLAGS = -shared
--
Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
