> - if (unlikely(nvme_req(req)->status && nvme_req_needs_retry(req))) { > - if (nvme_req_needs_failover(req)) { > + blk_status_t status = nvme_error_status(req); > + > + if (unlikely(status != BLK_STS_OK && nvme_req_needs_retry(req))) { > + if (nvme_req_needs_failover(req, status)) { We don't really need to call nvme_error_status if nvme_req(req)->status is zero. > -static inline bool nvme_req_needs_failover(struct request *req) > +static inline bool nvme_req_needs_failover(struct request *req, blk_status_t error) line break after 80 characters, please. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel