On Sat, Jan 06 2018 at 4:26P -0500,
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> We forgot to set the error code on this path so it means we accidentally
> return NULL. The caller is expecting error pointers and will crash
> with a NULL dereference.
>
> Fixes: faf782b1c93d ("dm mpath: optimize NVMe bio-based support")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index d1f32103ae86..0436a5466281 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -883,6 +883,7 @@ static struct pgpath *parse_path(struct dm_arg_set *as, struct path_selector *ps
> INIT_DELAYED_WORK(&p->activate_path, activate_path_work);
> if (setup_scsi_dh(p->path.dev->bdev, m, &ti->error)) {
> dm_put_device(ti, p->path.dev);
> + r = -EINVAL;
> goto bad;
> }
> }
Thanks for the report, but I prefer the following fix, which I'll fold
into the original commit:
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 99420b0ac2db..be581765edd1 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -882,7 +882,8 @@ static struct pgpath *parse_path(struct dm_arg_set *as, struct path_selector *ps
if (m->queue_mode != DM_TYPE_NVME_BIO_BASED) {
INIT_DELAYED_WORK(&p->activate_path, activate_path_work);
- if (setup_scsi_dh(p->path.dev->bdev, m, &ti->error)) {
+ r = setup_scsi_dh(p->path.dev->bdev, m, &ti->error);
+ if (r) {
dm_put_device(ti, p->path.dev);
goto bad;
}
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
