On Thu, 2017-12-07 at 12:49 -0600, Benjamin Marzinski wrote: > select_rr_weight() and select_pgfailback() don't need to be set each > time setup_multipath is called, since nothing ever changes the value > of the multipath variable that they set. > > select_flush_on_last_del() and select_no_path retry() are a little > more > involved. In multipathd, it is possible to override no_path_retry by > either setting flush_on_last_del, or by manually running the > "disablequeueing" mutipathd command. Queueing gets restored when a > path > gets added back to the multipath device. This was done by moving the > select_* functions into setup_multipath, where they frequently get > called unnecessarily. select_flush_on_last_del() can get removed by > simply using another variable besides flush_on_last_del to track > wether > or not we should be force queueing to be disabled. > > Since it's only possible to change whether or not you have queueing > force disabled by reloading the device with path, or by manually > restoring it, there is no reason to call select_no_path_retry() on > every > call to setup_multipath > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > --- Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> -- Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
