Re: [PATCH V5 8/8] blk-mq: improve bio merge from blk-mq sw queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH V5 8/8] blk-mq: improve bio merge from blk-mq sw queue
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 3 Oct 2017 02:21:43 -0700
Cc: Omar Sandoval <osandov@xxxxxx>, linux-block@xxxxxxxxxxxxxxx, Paolo Valente <paolo.valente@xxxxxxxxxx>, Laurence Oberman <loberman@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Jens Axboe <axboe@xxxxxx>, dm-devel@xxxxxxxxxx, Bart Van Assche <bart.vanassche@xxxxxxxxxxx>, Tom Nguyen <tom81094@xxxxxxxxx>
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4CADA25762
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7D001883C7
In-reply-to: <20170930112655.31451-9-ming.lei@redhat.com>
References: <20170930112655.31451-1-ming.lei@redhat.com> <20170930112655.31451-9-ming.lei@redhat.com>
User-agent: Mutt/1.8.3 (2017-05-23)

This looks generally good to me, but I really worry about the impact
on very high iops devices.  Did you try this e.g. for random reads
from unallocated blocks on an enterprise NVMe SSD?

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: [PATCH V5 8/8] blk-mq: improve bio merge from blk-mq sw queue
  - From: Ming Lei

References:
- [PATCH V5 0/8] blk-mq: improve bio merge for none scheduler
  - From: Ming Lei
- [PATCH V5 8/8] blk-mq: improve bio merge from blk-mq sw queue
  - From: Ming Lei

Prev by Date: Re: [PATCH V5 6/8] block: introduce .last_merge and .hash to blk_mq_ctx
Next by Date: Re: [PATCH] dm-crypt: Reject sector_size feature if device length is not aligned to it
Previous by thread: [PATCH V5 8/8] blk-mq: improve bio merge from blk-mq sw queue
Next by thread: Re: [PATCH V5 8/8] blk-mq: improve bio merge from blk-mq sw queue
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]