On Fri, 2017-09-15 at 15:40 -0500, Benjamin Marzinski wrote: > On Thu, Sep 14, 2017 at 03:06:43PM +0200, Martin Wilck wrote: > > Hi Ben, > > > > On Wed, 2017-09-13 at 16:19 -0500, Benjamin Marzinski wrote: > > > On Sun, Sep 03, 2017 at 12:38:50AM +0200, Martin Wilck wrote: > > > > If DM_ACTIVATION is set by the general dm rules, we need to > > > > bring up this device. But if the mpath device is not ready, > > > > that would be dangerous; it could hang or produce lots of IO > > > > errors. So remember this state, and try to activate when the > > > > map becomes usable later. > > > > > > NAK. See reasons in > > > > > > [PATCH 20/31] 11-dm-mpath.rules: don't set READY->ACTIVATION > > > > Sorry for being slow. Re-reading this, I don't understand any more > > why > > your valid argument against 20/31 invalidates this one as well. > > 21/31 > > affects only the case MPATH_DEVICE_READY!=0, in which case it will > > add > > another case where DM_ACTIVATION is set. > > If we are always setting DM_ACTIVATION when MPATH_DEVICE_READY > changes > from zero to non-zero, we don't need to remember that we had to > disable > DM_ACTIVATION when the device wasn't ready, and make sure to set it > now, because we are always setting it when we change to a device > ready > state... right? Err... yes. I guess I shouldn't post on udev rule logic after midnight. Sorry. Martin -- Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
