Hi Hannes, Thanks for improving DM-multipath over NVMe. Please find my comment. Cheers Guan Junxiong On 2017/9/15 14:30, Hannes Reinecke wrote: > Hi all, > > the current NVMe support is fairly rudimentary, and we've had reports > about spurious path failures under high load. > Which is a bit disappointing, seeing that high load is exactly what > NVMe is about ... > So here's a patchset to clean up the situation somewhat. > In particular: > - I've fixed up the discovery to fall in line with the other transports, > like filling out the sg_id fields (so that we're not greeted with weird > hashes in the topology output) Great, that is something I want to touch. IMO, it's better to use a union fields such as nvme_id fields which shows the true topology of NVMe/NVMf storage such as: host NQN ->portid->subsytem NQN ->controller ID ->namespace id . -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel