On 07/17/2017 04:23 AM, Yang Feng wrote: > I think there is a mistake: > 1. In fact, the tur checker feature has never been removed. The tur checker > has just been renamed to "ping" checker and the keep alive command checker > feature is added into this checker. So, the renamed checker remains "tur" > and add "keep alive". Absolutely, I agree that SCSI is going to stay for > some time to come, So it can support a SCSI device by "tur" and support a > NVMe device by "keep alive". > 2. If add a new checker for "keep alive", it maybe increase the redundancy > of code. And, when the SCSI LUN and the NVMe namespace are maped in the > same array for the same host, no matter which checker is choosed, it will > not be able to support the scenario very well. > 3. Using read() with O_DIRECT for path_latency can avoid this problem, but > can not fix this problem. There is no need to rename tur to ping. Same work can be done over tur.c. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
