>From 2/2:
"""
There are quite a number of occurrences in the kernel of the pattern
if (dst != src)
memcpy(dst, src, walk.total % AES_BLOCK_SIZE);
crypto_xor(dst, final, walk.total % AES_BLOCK_SIZE);
or
crypto_xor(keystream, src, nbytes);
memcpy(dst, keystream, nbytes);
where crypto_xor() is preceded or followed by a memcpy() invocation
that is only there because crypto_xor() uses its output parameter as
one of the inputs.
"""
Patch #1 is a preparatory patch, which is split off for ease of review.
Patch #2 updates all occurrences of crypto_xor() to use a separate
output argument.
Ard Biesheuvel (2):
crypto/algapi - use separate dst and src operands for __crypto_xor()
crypto/algapi - make crypto_xor() take separate dst and src arguments
arch/arm/crypto/aes-ce-glue.c | 4 +---
arch/arm/crypto/aes-neonbs-glue.c | 9 +++----
arch/arm64/crypto/aes-glue.c | 8 +++----
arch/arm64/crypto/aes-neonbs-glue.c | 9 +++----
arch/sparc/crypto/aes_glue.c | 3 +--
arch/x86/crypto/aesni-intel_glue.c | 4 ++--
arch/x86/crypto/blowfish_glue.c | 3 +--
arch/x86/crypto/cast5_avx_glue.c | 3 +--
arch/x86/crypto/des3_ede_glue.c | 3 +--
crypto/algapi.c | 25 ++++++++++++--------
crypto/ccm.c | 2 +-
crypto/chacha20_generic.c | 4 ++--
crypto/cmac.c | 8 +++----
crypto/ctr.c | 7 +++---
crypto/cts.c | 4 ++--
crypto/gcm.c | 4 ++--
crypto/ghash-generic.c | 2 +-
crypto/keywrap.c | 4 ++--
crypto/pcbc.c | 20 +++++++---------
crypto/salsa20_generic.c | 4 ++--
crypto/seqiv.c | 2 +-
crypto/xcbc.c | 8 +++----
drivers/crypto/vmx/aes_ctr.c | 3 +--
drivers/md/dm-crypt.c | 19 +++++++--------
include/crypto/algapi.h | 12 ++++++----
include/crypto/cbc.h | 10 ++++----
net/mac80211/fils_aead.c | 6 ++---
27 files changed, 89 insertions(+), 101 deletions(-)
--
2.9.3
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
