Re: [PATCH v3 1/1] multipath-tools: Prioritizer based on a latency algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/05/2017 04:43 AM, Yang Feng wrote:

> diff --git a/libmultipath/prioritizers/path_latency.c b/libmultipath/prioritizers/path_latency.c
> new file mode 100644
> index 0000000..081f546
> --- /dev/null
> +++ b/libmultipath/prioritizers/path_latency.c
> @@ -0,0 +1,272 @@
> +/*
> + * (C) Copyright HUAWEI Technology Corp. 2017, 2021   All Rights Reserved.

                                                  ^^^^  <-----------
2021 ???

> + *
> + * main.c
> + *
> + * Prioritizer for device mapper multipath, where the corresponding priority
> + * values of specific paths are provided by a latency algorithm. And the
> + * latency algorithm is dependent on arguments.
> + *
> + * The principle of the algorithm as follows:
> + * 1. By sending a certain number "io_num" of read IOs to the current path
> + *    continuously, the IOs' average latency can be calculated.
> + * 2. According to the average latency of each path and the weight value
> + *    "latency_interval", the priority "rc" of each path can be provided.
> + *
> + * Author(s): Yang Feng <philip.yang@xxxxxxxxxx>
> + *            Zou Ming <zouming.zouming@xxxxxxxxxx>
> + *            Guan Junxiong <guanjunxiong@xxxxxxxxxx>
> + *
> + * This file is released under the GPL.
                                      ^^^  <-----------

"GPL" is not a licence. The *version* must be specified.


And it would be nice to start using SPDX tags ( https://spdx.org/ )
for new files.


BTW: LFC191 Compliance Basics for Developers course is FREE
     https://training.linuxfoundation.org/linux-courses/open-source-compliance-courses/compliance-basics-for-developers

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel



[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux