Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
From: Logan Gunthorpe <logang@xxxxxxxxxxxx>
Date: Fri, 28 Apr 2017 10:53:45 -0600
Cc: linux-nvdimm@xxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Stephen Bates <sbates@xxxxxxxxxxxx>, dm-devel@xxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, devel@xxxxxxxxxxxxxxxxxxxx, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, open-iscsi@xxxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, sparmaintainer@xxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, Dan Williams <dan.j.williams@xxxxxxxxx>, megaraidlinux.pdl@xxxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-mmc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85E42C1CB3C7
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EC616C04D28B
In-reply-to: <20170428063039.GB6817@gondor.apana.org.au>
References: <1493144468-22493-1-git-send-email-logang@deltatee.com> <1493144468-22493-8-git-send-email-logang@deltatee.com> <20170427035603.GA32212@gondor.apana.org.au> <94123cbf-3287-f05e-7267-0bcf08ab0a8b@deltatee.com> <20170428063039.GB6817@gondor.apana.org.au>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0


On 28/04/17 12:30 AM, Herbert Xu wrote:
> You are right.  Indeed the existing code looks buggy as they
> don't take sg->offset into account when doing the kmap.  Could
> you send me some patches that fix these problems first so that
> they can be easily backported?

Ok, I think the only buggy one in crypto is hifn_795x. Shash and caam
both do have the sg->offset accounted for. I'll send a patch for the
buggy one shortly.

Logan

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
  - From: Herbert Xu

References:
- [PATCH v2 00/21] Introduce common scatterlist map function
  - From: Logan Gunthorpe
- [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
  - From: Logan Gunthorpe
- Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
  - From: Herbert Xu
- Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
  - From: Logan Gunthorpe
- Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
  - From: Herbert Xu

Prev by Date: Re: [PATCH 25/27] block: remove the discard_zeroes_data flag
Next by Date: Re: [PATCH 25/27] block: remove the discard_zeroes_data flag
Previous by thread: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
Next by thread: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]