Re: [PATCH] dm ioctl: prevent stack leak in dm ioctl call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] dm ioctl: prevent stack leak in dm ioctl call
From: Alasdair G Kergon <agk@xxxxxxxxxx>
Date: Thu, 27 Apr 2017 16:43:48 +0100
Cc: dm-devel@xxxxxxxxxx, mpatocka@xxxxxxxxxx, snitzer@xxxxxxxxxx
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BD93D46D093
In-reply-to: <CAEP91RFJTRk7Ux3W=1TMfgjzF1cMc5jXF+om4Qchh8RDx84MtQ@mail.gmail.com>
Mail-followup-to: Adrian Salido <salidoa@xxxxxxxxxx>, snitzer@xxxxxxxxxx, dm-devel@xxxxxxxxxx, mpatocka@xxxxxxxxxx
Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: Peninsular House, 30-36 Monument Street, 4th Floor, London, England, EC3R 8NB.
References: <20170425233129.GA155598@google.com> <20170426001117.GA7433@agk-dp.fab.redhat.com> <CAEP91RFJTRk7Ux3W=1TMfgjzF1cMc5jXF+om4Qchh8RDx84MtQ@mail.gmail.com>
User-agent: Mutt/1.5.18 (2008-05-17)

On Tue, Apr 25, 2017 at 05:33:19PM -0700, Adrian Salido wrote:
> Will update the patch to be clear
 
So at the moment, we're leaning towards just:

  param->data_size = offsetof(struct dm_ioctl, data)

to replace

  param->data_size = sizeof(*param);

in the caller.

Alasdair

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: [PATCH] dm ioctl: prevent stack leak in dm ioctl call
  - From: Adrian Salido
- [PATCH v2] dm ioctl: prevent stack leak in dm ioctl call
  - From: Adrian Salido

References:
- [PATCH] dm ioctl: prevent stack leak in dm ioctl call
  - From: Adrian Salido
- Re: [PATCH] dm ioctl: prevent stack leak in dm ioctl call
  - From: Alasdair G Kergon
- Re: [PATCH] dm ioctl: prevent stack leak in dm ioctl call
  - From: Adrian Salido

Prev by Date: Re: [PATCH 02/13] dm-mpath: Avoid that path removal can trigger an infinite loop
Next by Date: Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions
Previous by thread: Re: [PATCH] dm ioctl: prevent stack leak in dm ioctl call
Next by thread: [PATCH v2] dm ioctl: prevent stack leak in dm ioctl call
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]