Re: [PATCH 11/23] dm rq: don't pass irrelevant error code to blk_mq_complete_request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 11/23] dm rq: don't pass irrelevant error code to blk_mq_complete_request
From: Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx>
Date: Thu, 20 Apr 2017 15:25:37 +0000
Accept-language: en-US
Cc: "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "jbacik@xxxxxx" <jbacik@xxxxxx>, "james.smart@xxxxxxxxxxxx" <james.smart@xxxxxxxxxxxx>, "linux-nvme@xxxxxxxxxxxxxxxxxxx" <linux-nvme@xxxxxxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A19D52FE544
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4C0AD64DA9
In-reply-to: <20170420140316.6546-12-hch@lst.de>
References: <20170420140316.6546-1-hch@lst.de> <20170420140316.6546-12-hch@lst.de>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
Wdcipoutbound: EOP-TRUE

On Thu, 2017-04-20 at 16:03 +0200, Christoph Hellwig wrote:
> dm never uses rq->errors, so there is no need to pass an error argument
> to blk_mq_complete_request.

Reviewed-by: Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx>

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

References:
- kill req->errors V4
  - From: Christoph Hellwig
- [PATCH 11/23] dm rq: don't pass irrelevant error code to blk_mq_complete_request
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 23/23] block: remove the errors field from struct request
Next by Date: Re: [PATCH 12/23] dm mpath: don't check for req->errors
Previous by thread: Re: [PATCH 11/23] dm rq: don't pass irrelevant error code to blk_mq_complete_request
Next by thread: [PATCH 09/23] loop: zero-fill bio on the submitting cpu
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]