Re: [PATCH 01/23] pd: don't check blk_execute_rq return value.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 01/23] pd: don't check blk_execute_rq return value.
From: Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx>
Date: Wed, 19 Apr 2017 21:02:33 +0000
Accept-language: en-US
Cc: "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "jbacik@xxxxxx" <jbacik@xxxxxx>, "james.smart@xxxxxxxxxxxx" <james.smart@xxxxxxxxxxxx>, "linux-nvme@xxxxxxxxxxxxxxxxxxx" <linux-nvme@xxxxxxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D2892C04BD3E
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 20C4389C34
In-reply-to: <20170419192708.22098-2-hch@lst.de>
References: <20170419192708.22098-1-hch@lst.de> <20170419192708.22098-2-hch@lst.de>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
Wdcipoutbound: EOP-TRUE

On Wed, 2017-04-19 at 21:26 +0200, Christoph Hellwig wrote:
> The driver never sets req->errors, so blk_execute_rq will always return 0.

Reviewed-by: Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx>

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

References:
- kill req->errors V3
  - From: Christoph Hellwig
- [PATCH 01/23] pd: don't check blk_execute_rq return value.
  - From: Christoph Hellwig

Prev by Date: [PATCH 03/23] nvme-fc: fix status code handling in nvme_fc_fcpio_done
Next by Date: Re: [PATCH 02/23] block: remove the blk_execute_rq return value
Previous by thread: [PATCH 01/23] pd: don't check blk_execute_rq return value.
Next by thread: [PATCH 23/23] block: remove the errors field from struct request
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]