Christoph Hellwig <hch@xxxxxx> writes: > Split sd_setup_discard_cmnd into one function per provisioning type. While > this creates some very slight duplication of boilerplate code it keeps the > code modular for additions of new provisioning types, and for reusing the > write same functions for the upcoming scsi implementation of the Write Zeroes > operation. Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> Minor nit: Patch header should be "sd: ..." instead of " d: ...". -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel