Re: [PATCH v3] block: trace completion of all bios.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3] block: trace completion of all bios.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 27 Mar 2017 02:03:08 -0700
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Ming Lei <tom.leiming@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, dm-devel@xxxxxxxxxx, Shaohua Li <shli@xxxxxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 49DFF7F342
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0A6E2C05AA53
In-reply-to: <87fui3a65o.fsf@notabene.neil.brown.name>
References: <877f3iave6.fsf@notabene.neil.brown.name> <20170322125149.GA29606@infradead.org> <87shm4a4lt.fsf@notabene.neil.brown.name> <20170323104331.GA16903@ming.t460p> <87fui3a65o.fsf@notabene.neil.brown.name>
User-agent: Mutt/1.7.1 (2016-10-04)

I don't really like the flag at all.  I'd much prefer a __bio_endio
with a 'bool trace' flag.  Also please remove the manual tracing in
dm.ċ.  Once that is done I suspect we can also remove the
block_bio_complete export.

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: [PATCH v3] block: trace completion of all bios.
  - From: NeilBrown

References:
- [PATCH] block: trace completion of all bios.
  - From: NeilBrown
- Re: [PATCH] block: trace completion of all bios.
  - From: Christoph Hellwig
- [PATCH v2] block: trace completion of all bios.
  - From: NeilBrown
- Re: [PATCH v2] block: trace completion of all bios.
  - From: Ming Lei
- [PATCH v3] block: trace completion of all bios.
  - From: NeilBrown

Prev by Date: Re: [PATCH 06/23] dm-kcopyd: switch to use REQ_OP_WRITE_ZEROES
Next by Date: Re: [PATCH v3] block: trace completion of all bios.
Previous by thread: Re: [PATCH v3] block: trace completion of all bios.
Next by thread: Re: [PATCH v3] block: trace completion of all bios.
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]