On Thu, Jan 26, 2017 at 11:12:51AM -0800, Bart Van Assche wrote: > Where does the '* 3' come from? I think that deserves a comment. > Additionally, this patch introduces a new warning when building with W=1: It's a magic factor copied from the old code :( That beeing said I really wonder if we should keep the tracing for the scsi_requests fields at all. We have tracing in SCSI, and poking into these SCSI fields from block code is painful and just screams layering violations. Jens, any opinion on just removing the printout of the SCSI CDB for blktrace? -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
