On Wed, Jan 04, 2017 at 09:33:26PM +0100, Martin Wilck wrote: > On Wed, 2017-01-04 at 12:14 -0600, Benjamin Marzinski wrote: > > > > The other option would be to not actually merge the uevents, but > > simply > > run through the filtered but unmerged list of uevents, and skip the > > domap stuff but remember the maps that need pushing to device-mapper. > > Once you are done processing all the uevents, except for updating the > > maps in device-mapper, you go back and update all the maps that need > > updating. There's more code refactoring in this approach, but it > > keeps > > the uid being set in pathinfo, where you have all the information > > necessary to set it using uid_attribute, getuid, or specialized code > > like rbd uses. > > That sounds a lot like configure()/coalesce_paths() to me. Would it > perhaps make sense, instead of refactoring/rewriting a whole lot of > code, to re-use that mature code path? Like I mentioned before, configure does a lot of extra unnecessary work, and currently has the problem of dropping information about failed paths. -Ben > > Cheers, > Martin > > -- > Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
