Re: [PATCH 2/2] multipathd: skip spurious event message for blacklisted paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ben,

On 12/12/2016 01:20 PM, Mauricio Faria de Oliveira wrote:
On 12/12/2016 12:23 PM, Benjamin Marzinski wrote:
Why don't we just call pathinfo here? I see that you set the pathvec to
NULL so that you don't actually store the path, but this sure does a lot
of unnecessary work before failing. AFAICT, just calling pathinfo with
DI_BLACKLIST already gets you what you need (it checks both the device
and wwid blacklists). Am I missing something here?

path_discover() also calls filter_property() and filter_devnode(),
so more blacklisting methods are covered.

(filter_devnode() is also checked by uev_trigger(), but I wanted
to reuse the existing code to keep the patch simple.)

I found a better way to do this which should also honor your point
about the unnecessary work/overhead; PATCH v2 on the way.

--
Mauricio Faria de Oliveira
IBM Linux Technology Center

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel



[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux