On 11/26/16 14:26, Xose Vazquez Perez wrote: > Is there anything else missing or leftover? > > $ git grep "(CC)" > Makefile.inc: $(CC) $(CFLAGS) -c -o $@ $< > kpartx/Makefile: $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS) $(LIBDEPS) > libmpathcmd/Makefile: $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) $(LIBDEPS) > libmpathpersist/Makefile: $(CC) -c $(CFLAGS) *.c > libmpathpersist/Makefile: $(CC) $(LDFLAGS) $(SHARED_FLAGS) $(LIBDEPS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) > libmultipath/Makefile: $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) $(LIBDEPS) > libmultipath/checkers/Makefile: $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -lrados -ludev > libmultipath/checkers/Makefile: $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -laio > libmultipath/checkers/Makefile: $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > libmultipath/prioritizers/Makefile: $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > libmultipath/prioritizers/Makefile: $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > mpathpersist/Makefile: $(CC) $(OBJS) -o $(EXEC) $(LDFLAGS) $(CFLAGS) $(LIBDEPS) > multipath/Makefile: $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS) $(LIBDEPS) > multipathd/Makefile: $(CC) $(CFLAGS) $(OBJS) $(LDFLAGS) -o $(EXEC) $(LIBDEPS) > > > Cc: Christophe Varoqui <christophe.varoqui@xxxxxxxxxxx> > Cc: device-mapper development <dm-devel@xxxxxxxxxx> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx> > --- > libmultipath/checkers/Makefile | 6 +++--- > libmultipath/prioritizers/Makefile | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libmultipath/checkers/Makefile b/libmultipath/checkers/Makefile > index 11ab76f..c44c08e 100644 > --- a/libmultipath/checkers/Makefile > +++ b/libmultipath/checkers/Makefile > @@ -19,13 +19,13 @@ LIBS= \ > all: $(LIBS) > > libcheckrbd.so: rbd.o > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -lrados -ludev > + $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -lrados -ludev > > libcheckdirectio.so: libsg.o directio.o > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -laio > + $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -laio > > libcheck%.so: libsg.o %.o > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > + $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > > install: > $(INSTALL_PROGRAM) -m 755 $(LIBS) $(DESTDIR)$(libdir) > diff --git a/libmultipath/prioritizers/Makefile b/libmultipath/prioritizers/Makefile > index 36b42e4..e85a9d8 100644 > --- a/libmultipath/prioritizers/Makefile > +++ b/libmultipath/prioritizers/Makefile > @@ -23,10 +23,10 @@ LIBS = \ > all: $(LIBS) > > libprioalua.so: alua.o alua_rtpg.o > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > + $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > > libprio%.so: %.o > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > + $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > > install: $(LIBS) > $(INSTALL_PROGRAM) -m 755 libprio*.so $(DESTDIR)$(libdir) Hello Xose, What is the purpose of this patch and why do you think it is useful? It is already possible to specify flags for linking shared libraries through LDFLAGS. I don't see why CFLAGS should be added to the shared library creation commands. Additionally, automake also ignores CFLAGS when linking shared libraries. See also https://www.gnu.org/software/automake/manual/html_node/Libtool-Flags.html#Libtool-Flags. Bart. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
