On 10/29/2016 04:55 AM, Benjamin Marzinski wrote:
uev_update_path was not checking pp->initialized to see if multipathd had requested that the path be reinitialized unless the path's read-only state had changed. This kept the reinitialization code from running in most cases where it was supposed to. This patch reorders the function to move that check outside the read-only status change code block. This does mean that uev_update_path now always grabs the vecs lock, where before it would only be grabbed if the read-only status had changed. If people are worried about this, I can add some code to limit this so that uev_update_path will only grab it if there is a chance that it needs to reinitialize the path. Cc: Hannes Reinecke <hare@xxxxxxx> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> --- multipathd/main.c | 54 +++++++++++++++++++----------------------------------- 1 file changed, 19 insertions(+), 35 deletions(-)
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
