From: "tang.junhui" <tang.junhui@xxxxxxxxxx> m->hw_handler_name value should be checked in parse_hw_handler() after calling kstrdup() to avoid access of NULL pointer. Signed-off-by: tang.junhui <tang.junhui@xxxxxxxxxx> --- drivers/md/dm-mpath.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index d376dc8..77428fb 100644 --- a/drivers/md/dm-mpath.c +++ b/drivers/md/dm-mpath.c @@ -732,6 +732,9 @@ static int parse_hw_handler(struct dm_arg_set *as, struct multipath *m) return 0; m->hw_handler_name = kstrdup(dm_shift_arg(as), GFP_KERNEL); + if (!m->hw_handler_name) + return -ENOMEM; + if (!try_then_request_module(scsi_dh_handler_exist(m->hw_handler_name), "scsi_dh_%s", m->hw_handler_name)) { ti->error = "unknown hardware handler type"; -- 2.8.1.windows.1 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel