On 10/24/16 03:50, Germano Percossi wrote:
On 10/21/2016 07:43 PM, Bart Van Assche wrote:
The function snprint_config() is not used. Hence remove it.
Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
---
libmultipath/print.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/libmultipath/print.c b/libmultipath/print.c
index 9aa41ad..09e4a2e 100644
--- a/libmultipath/print.c
+++ b/libmultipath/print.c
@@ -1745,12 +1745,6 @@ snprint_devices (struct config *conf, char * buff, int len, struct vectors *vecs
return fwd;
}
-extern int
-snprint_config (char * buff, int len)
-{
- return 0;
-}
-
/*
* stdout printing helpers
*/
> Removing functions packaged in a library just because they are
> not used in multipath does not seem fine, in general.
> They could still be used by third party.
Hello Germano,
The snprint_config() function has never been declared in any
multipath-tools header file so if someone would want to use this
function without triggering a compiler warning they would have to add
something like "extern int snprint_config (char * buff, int len)" to
their source code. Because of this reason and also because of the empty
implementation I think that is unlikely that any project is using this
function.
Bart.
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
