Re: [PATCH] mpathpersist: memset length is wrong

[Christophe Varoqui <christophe.varoqui@xxxxxxxxxxx>]

Seems right.

Merged, with thanks.

On Tue, Oct 11, 2016 at 8:37 AM, <tang.junhui@xxxxxxxxxx> wrote:

Please have a review for this patch, any comment will be highly appreciated.




发件人:         tang.junhui@xxxxxxxxxx
收件人:         christophe varoqui <christophe.varoqui@xxxxxxx>, Chauhan@xxxxxxxxxx, Vijay <Vijay.Chauhan@xxxxxxxxxx>, Benjamin Marzinski <bmarzins@xxxxxxxxxx>,
抄送:        zhang.kai16@xxxxxxxxxx, dm-devel@xxxxxxxxxx, "tang.junhui" <tang.junhui@xxxxxxxxxx>
日期:         2016/09/21 16:54
主题:         [PATCH] mpathpersist: memset length is wrong
发件人:        dm-devel-bounces@xxxxxxxxxx

---

From: "tang.junhui" <tang.junhui@xxxxxxxxxx>

variable transportids is cleared by memset() with wrong length MPATH_MX_TIDS,
the length should be MPATH_MX_TIDS*sizeof(struct transportid).

Signed-off-by: tang.junhui <tang.junhui@xxxxxxxxxx>
---
mpathpersist/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mpathpersist/main.c b/mpathpersist/main.c
index a55865f..8e8cc35 100644
--- a/mpathpersist/main.c
+++ b/mpathpersist/main.c
@@ -105,7 +105,7 @@ int main (int argc, char * argv[])

                 udev = udev_new();
                 conf = mpath_lib_init(udev);
-                 memset(transportids,0,MPATH_MX_TIDS);
+                 memset(transportids, 0, MPATH_MX_TIDS * sizeof(struct transportid));
                 multipath_conf = conf;

                 while (1)
--
2.8.1.windows.1

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel