Re: [PATCH 00/15] Fifteen multipath-tools patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/07/2016 07:05 PM, tang.junhui@xxxxxxxxxx wrote:
"0007-multipathd-Fix-a-data-race.patch"

This patch solved the data race problem,

but the assignment for paths check interval has no effect,

since there is no path in vecs when calling
init_path_check_interval(vecs) in child(),

I think it is better to call
 init_path_check_interval(vecs) at reconfigure() or configure()

after the paths has created in vecs .

Hello Tang,

If init_path_check_interval() doesn't have any effect then I propose to remove that function. pp->checkint is namely already initialized in cli_add_path().

Bart.

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel



[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux