Re: [PATCH RFC] dm: Fix a bio leak in dec_pending()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/26/2016 07:57 AM, Mike Snitzer wrote:
On Thu, Aug 25 2016 at  4:57pm -0400,
Bart Van Assche <bart.vanassche@xxxxxxxxxxx> wrote:

Ensure that bio_endio() is called if io->error == DM_ENDIO_REQUEUE and
__noflush_suspending(md) returns false. Posting this as an RFC since I'm
not really familiar with the dm code.

Fixes: commit 2e93ccc1933d ("dm: suspend: add noflush pushback")
Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
Cc: Kiyoshi Ueda <k-ueda@xxxxxxxxxxxxx>

I did reinstate bio-based multipath recently.  But I just want to make
sure: you realize that dec_pending() is only ever used by bio-based DM
right? (dm-mq and .request_fn multipath are request-based)

Hello Mike,

Yes, I am aware that this code is not triggered by my tests. This is something I noticed while reading the dm source code and something I wanted to report.

Bart.

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel



[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux