On 08/23/16 06:57, Bart Van Assche wrote: > On 08/22/16 11:32, Mikko Rapeli wrote: >> - * uint32_t (*get_region_size)(struct dm_dirty_log *log); >> + * __u32 (*get_region_size)(struct dm_dirty_log *log); > > uint32_t is a type that is defined by ANSI C but __u32 not. So this > change looks wrong to me. Would it have been sufficient to add "#include > <linux/types.h>" and keep the uint32_t etc. type names? Answering my own question: adding "#include <linux/types.h>" wouldn't be sufficient. How about adding the following code that also occurs in a few other uapi header files? #ifndef __KERNEL__ #include <stdint.h> #endif #include <linux/types.h> Bart. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel