On 08/12/2016 11:33 AM, Xose Vazquez Perez wrote:
On 08/12/2016 08:10 PM, Bart Van Assche wrote:
It seems like a patch description that motivates why this change is
>> considered useful is missing completely? Anyway, have you considered
>> to use a name that is consistent by what is expected by automake,
>> namely LDADD (see also
https://www.gnu.org/software/automake/manual/html_node/Linking.html#Linking)?
I followed just same rule as in the rest of multipath-tools'
Makefiles. Where it's called "LIBDEPS":
libmpathpersist/Makefile:LIBDEPS += -lpthread -ldevmapper -ldl -L$(multipathdir) -lmultipath \
libmultipath/Makefile: LIBDEPS += -lsystemd
libmultipath/Makefile: LIBDEPS += -lsystemd-daemon
Hello Xose,
Thanks for the clarification. Since LIBDEPS is already used elsewhere in
multipath-tools makefiles I'm fine with using that name. I don't think
it's worth to rename all uses of LIBDEPS in other Makefiles.
Bart.
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
