Re: [PATCH 1/2] multipath-tools: change default failback from manual to immediate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/11/2016 11:12 PM, Xose Vazquez Perez wrote:
> Default value is: manual
>       1                 .pgfailback    = 15,
>       2                 .pgfailback    = 30,
>      24                 .pgfailback    = FAILBACK_UNDEF,
>      50                 .pgfailback    = -FAILBACK_IMMEDIATE,
> 
> manual is not used by any device.
> 
> Cc: Christophe Varoqui <christophe.varoqui@xxxxxxxxxxx>
> Cc: device-mapper development <dm-devel@xxxxxxxxxx>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx>
> ---
>  libmultipath/defaults.h    |  2 +-
>  libmultipath/hwtable.c     | 50 ----------------------------------------------
>  multipath/multipath.conf.5 |  2 +-
>  3 files changed, 2 insertions(+), 52 deletions(-)
> 
Please revert.

'immediate' fallback only makes sense if the device has a working
prioritizer _and_ supports a 'preferred path'.
None of which can be assumed for an unknown device, so this patch
will break automatic configuration.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@xxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux