Re: [PATCH 1/1] multipath-tools: fix dm- device filtering

[Christophe Varoqui <christophe.varoqui@xxxxxxxxxxx>]

Rebased and merged.

Thanks.

On Tue, Jul 5, 2016 at 10:46 PM, Dragan Stancevic <dragan.stancevic@xxxxxxxxxxxxx> wrote:

During "service multipath-tools start" /sbin/multipath is

called on dm- devices that are filtered but due to a condition

conf->dev_type == DEV_DEVNODE in filtering code multipath

binary wasn't dropping out when hitting a dm- device. This

was due to the fact that in this case conf->dev_type is

set to DEV_UEVENT.

This is causing the logs to be filled with following

messages:

multipath: dm-6: failed to get udev uid: Invalid argument

multipath: dm-6: failed to get sysfs uid: Invalid argument

multipath: dm-6: failed to get sgio uid: No such file or directory

This change alows the filtering to happen.

Cc: Christophe Varoqui <christophe.varoqui@xxxxxxxxxxx>

Cc: device-mapper development <dm-devel@xxxxxxxxxx>

Signed-off-by: Dragan Stancevic <dragan.stancevic@xxxxxxxxxxxxx>

---

 multipath/main.c | 3 ++- 

 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/multipath/main.c b/multipath/main.c

index aadebec..d89298b 100644

--- a/multipath/main.c

+++ b/multipath/main.c

@@ -267,7 +267,8 @@ configure (void)

        /*

         * if we have a blacklisted device parameter, exit early

         */

-       if (dev && conf->dev_type == DEV_DEVNODE &&

+       if (dev && (conf->dev_type == DEV_DEVNODE ||

+                   conf->dev_type == DEV_UEVENT) &&

            conf->cmd != CMD_REMOVE_WWID &&

            (filter_devnode(conf->blist_devnode,

                            conf->elist_devnode, dev) > 0)) {

-- 

2.1.0

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel