Re: [PATCH] multipath-tools: add Pure Storage device to hardware table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/14/2016 07:56 AM, Hannes Reinecke wrote:

> On 06/13/2016 06:30 PM, Xose Vazquez Perez wrote:
> [...]
>> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
>> index a126b7c..c4258e1 100644
>> --- a/libmultipath/hwtable.c
>> +++ b/libmultipath/hwtable.c
>> @@ -1195,6 +1195,22 @@ static struct hwentry default_hw[] = {
>>  		.minio         = 128,
>>  	},
>>  	/*
>> +	 * Pure Storage, Inc.
>> +	 *
>> +	 * Maintainer : Christophe Varoqui
>> +	 * Mail : christophe.varoqui@xxxxxxxxxxx
>> +	 */
>>
> Please drop the 'Maintainer' line.
> Christophe is the maintainer of the multipath-tools package itself, so
> everything which doesn't have an explicit owner is maintained by him anyway.
>
> Plus I think it's a bad style, appointing someone to become a maintainer
> without having asked first.

It was made that way originally, see 1b6188ce. So I followed the stream.
But I see lately any patch for new hardware includes a maintainer.

Even the controller/vendor families were disorganized.

I will do it.

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel



[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux