On 06/13/2016 07:02 PM, Xose Vazquez Perez wrote:
> Replace TUR checker with RDAC for:
> "OPENstorage D280"
> "STK6580_6780"
>
> I don't know if it's a bug or feature, but for all other RDAC devices
> "hwhandler" "checker" and "prio" are rdac.
>
> *This patch needs an explicit ACK from Hannes and Christophe*
>
> Cc: Hannes Reinecke <hare@xxxxxxx>
> Cc: Christophe Varoqui <christophe.varoqui@xxxxxxxxxxx>
> Cc: device-mapper development <dm-devel@xxxxxxxxxx>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx>
> ---
> libmultipath/hwtable.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index c4258e1..44a4669 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -949,7 +949,7 @@ static struct hwentry default_hw[] = {
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .checker_name = TUR,
> + .checker_name = RDAC,
> .prio_name = PRIO_RDAC,
> .prio_args = NULL,
> },
> @@ -981,7 +981,7 @@ static struct hwentry default_hw[] = {
> .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .checker_name = TUR,
> + .checker_name = RDAC,
> .prio_name = PRIO_RDAC,
> .prio_args = NULL,
> },
>
Actually it doesn't matter; 'TUR' will work better under high I/O load,
whereas RDAC has quirks for some array-specific settings.
But for consistencies sake we should be switching to 'RDAC' here, too.
Acked-by: Hannes Reinecke <hare@xxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
