On 05/03/2016 03:44 PM, Jeff Moyer wrote: > mchristi@xxxxxxxxxx writes: > >> The following patches begin to cleanup the request->cmd_flags and >> bio->bi_rw mess. We currently use cmd_flags to specify the operation, >> attributes and state of the request. For bi_rw we use it for similar >> info and also the priority but then also have another bi_flags field >> for state. At some point, we abused them so much we just made cmd_flags >> 64 bits, so we could add more. >> >> The following patches seperate the operation (read, write discard, >> flush, etc) from cmd_flags/bi_rw. >> >> This patchset was made against linux-next from today April 15 >> (git tag next-20160415). >> >> I put a git tree here: >> https://github.com/mikechristie/linux-kernel.git >> The patches are in the op branch. > > Hi, Mike, > > That git tree doesn't seem to exist. I did manage to apply your patch > set on top of next-20160415, though. > > So... what testing did you do? ;-) I ran into the following problems I normally run xfstests and run it on my daily workstation and laptop. I did not do this for every FS this time and hit a regression. What FS were you using? > - git clone fails > - yum segfaults In v7/v6, I missed a new submit_bio call, so I hit issues like the two above. I have this fixed in the next version. > - many blktrace/blkparse issues, including incorrect cpu recorded in > traces, null task names, and blkparse outputting nothing for a trace > file several gigabytes in size. I will double check for these issues. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
