Re: [PATCH 30/57] multipathd: skip uninitialized devices during reconfiguration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/02/2016 09:14 PM, Benjamin Marzinski wrote:
> On Wed, Apr 27, 2016 at 01:10:31PM +0200, Hannes Reinecke wrote:
>> libudev has a separate filter setting to skip uninitialized
>> devices during enumeration.
> 
> So, I assume if udev filters out a device here, it's because a uevent
> should be coming when the device is fully initialized. correct?
> 
Correct.

> The only thing I worry about with taking out all of the backup stuff is
> what happens if udev simply times out processing an event, and doesn't
> grab the UUID.  In this case we still won't get a UUID unless we force
> another event, or grab the information ourselves.
> 
Well, but we won't be seeing the event, either.
(If udev has timed out an event it won't be processed further, so it
will never show up on the udev event queue.)

However, there is a reason why I posted all work-arounds we've queued
together with this patch.

In the end, the udev integration stuff has fanned out across several
patches, where it's now really hard to figure out which bits are really
required.
So I'd prefer to leave them in; we can always remove them later.

> But ACK on the patch itself.
> 
Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@xxxxxxx			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux