On 18 April 2016 at 13:45, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Apr 18, 2016 at 01:31:09PM +0800, Baolin Wang wrote: >> >> We've tried to do this in dm-crypt, but it failed. >> The dm-crypt maintainer explained to me that I should optimize the >> driver, not add strange hw-dependent crypto modes to dm-crypt, this is >> not the first crypto accelerator that is just not suited for this kind >> of use. >> He thought if it can process batch of chunks of data each with own IV, >> then it can work with dm-crypt, but he thought such optimized code >> should be inside crypto API, not in dmcrypt. > > That's a completely bogus argument. The user always has more > information available than the underlying API. So it is totally > stupid to have the API try to extract information that the user > could have provided in the first place. If the crypto hardware engine can support bulk data encryption/decryption, so the engine driver can select bulk mode to handle the requests. I think it is a totally driver things, not in dmcrypt. The dmcrypt can not get the hardware engine's attributes. > > I'm not taking this patch-set. > > Cheers, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- Baolin.wang Best Regards -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
