On Tue, Dec 08 2015 at 10:42am -0500, Arnd Bergmann <arnd@xxxxxxxx> wrote: > The dm verity sec implementation uses do_div for dividing a sector_t, > which is slower than necessary when sector_t is a 32-bit type, and > we now get a warning for this case: > > include/asm-generic/div64.h:224:22: warning: passing argument 1 of '__div64_32' from incompatible pointer type [-Wincompatible-pointer-types] > drivers/md/dm-verity-fec.c:725:6: note: in expansion of macro 'do_div' > if (do_div(f->rounds, f->rsn)) > > This changes the code to use sector_div instead, which does the > right thing and avoids the warning. Thanks, I'll fold this in. (Btw, I did review this use of do_div(): but only to answer whether there was potential for a 64bit divide. I concluded do_div() was fine but didn't look to see the data type for f->rounds was actually sector_t.) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
