On Mon, Nov 09 2015 at 2:19P -0500, Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote: > On Mon, Nov 09, 2015 at 11:37:35AM -0500, Mike Snitzer wrote: > > I'm left wondering: can the new error correction code be made an > > optional feature that is off by default? -- so as to preserve some > > isolation of this new code from the old dm-verity behaviour. > > It's optional in the sense that you must specify error correction > parameters in the table to turn it on. Otherwise, verity_dec_decode > returns -1 and dm-verity handles errors as before. > > > might be good to add a wrapper like verity_fec_is_enabled(). > > Sure. I can do this in v2 and address the other feedback and build > issues as well. Hi Sami, Any progress on v2 that takes into account previous review feedback? Note I've staged the first 2 patches in this series for Linux 4.5 inclusion, see: https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-4.5 Mike -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
