On 11 November 2015 at 17:48, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Wed, Nov 11, 2015 at 05:31:43PM +0800, Baolin Wang wrote: >> Now the dm-crypt code only implemented the 'based-bio' method to encrypt/ >> decrypt block data, which can only hanle one bio at one time. As we know, >> one bio must use the sequential physical address and it also has a limitation >> of length. Thus it may limit the big block encyrtion/decryption when some >> hardware support the big block data encryption. >> >> This patch series introduc the 'based-request' method to handle the data >> encryption/decryption. One request can contain multiple bios, so it can >> handle big block data to improve the efficiency. > > NAK for more request based stacking or DM drivers. They are a major > pain to deal with, and adding more with different requirements then > dm-multipath is not helping in actually making that one work properly. But now many vendors supply the hardware engine to handle the encyrtion/decryption. The hardware really need a big block to indicate its performance with request based things. Another thing is now the request based things is used by many vendors (Qualcomm, Spreadtrum and so on) to improve their performance and there's a real performance requirement here (I can show the performance result later). I don't think you will worry if any one can work properly, we will remove the bio based things in future if the request things are accepted and proved effectively. Thanks for your comment. -- Baolin.wang Best Regards -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
