>>>>> "Dan" == Williams, Dan J <dan.j.williams@xxxxxxxxx> writes: Dan> Martin pointed out that I broke compatibility by changing the sysfs Dan> layout of the integrity attributes. Rather than add a sysfs-link Dan> we can make this patch simpler by only moving struct blk_integrity Dan> to request_queue and leave integrity_kobj where it is in gendisk. Dan> Also undo the conversion of blk_integrity apis take a Dan> request_queue. Through this simplification I also noticed that I Dan> had broken blk_integrity_compare() Dan> Here's the much smaller v3, and I also refreshed Dan> for-4.4/blk-integrity Much better. I ran some test on our combined trees over the weekend and tripped a bug on some SCSI configs. Turned out to be my fault so I'll repost with a fixed patch 2. You can either rebase on top of the new series or maybe Jens will merge my patches first. Either way works for me. In any case I'm OK with your latest changes. Feel free to add my Acked-by. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel